SuccessChanges

Summary

  1. added a property nodelist.contains.v2.mn that to set the nodeListContainsV2Mn property. Set the property to false in the context.SANDBOX.test.properties. Adjusted TestSettings to allow the property to be set from the command line (-D arguments)
  2. Added checks in a few functional test implementations for the ContextAwareTestCaseDataone property that is set based on whether we have v2 nodes in the environment. Some tests will be skipped without v2 nodes in environment.
  3. Added a nodeListContainsV2Mn property. It was being set automatically based on the CN node list, but disabled that for now per a discussion with rob since we may just change it to be an environment property.
  4. added optimization to the createTestObject method in SidCNTestImpl to minimize wait-to-sync time.
  5. Added a more specific error message and modified some v2 node checks to be even more strict
  6. Reverted recent change - object creation test code, in the case that we have a v2 CN.create() with no v2 MNs in the environment, will not fall back to a v1 MN for the authMN because this changes the expected behavior of some tests (tests that are expecting a v2-specific object to be created, aka an object with a v2 authMN). Better that it fail for not finding a v2 authMN than sneakily doing a v1 create where a v2 create is expected.
  7. Object creation test code fix - in the case that we have a v2 CN.create() with no v2 MNs in the environment, fall back to a v1 MN for the authMN.
  8. Improved a few log messages.
  9. Removed a line that shouldn't have been part of last commit
  10. Fixed a bad typo
Revision 16976 by rnahf:
added a property nodelist.contains.v2.mn that to set the nodeListContainsV2Mn property.  Set the property to false in the context.SANDBOX.test.properties. Adjusted TestSettings to allow the property to be set from the command line (-D arguments)
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/main/java/org/dataone/configuration/TestSettings.javasrc/main/java/org/dataone/configuration/TestSettings.java
The file was modified/software/cicore/trunk/d1_integration/src/main/java/org/dataone/integration/ContextAwareTestCaseDataone.javasrc/main/java/org/dataone/integration/ContextAwareTestCaseDataone.java
The file was modified/software/cicore/trunk/d1_integration/src/main/java/org/dataone/integration/IntegrationTestContextParameters.javasrc/main/java/org/dataone/integration/IntegrationTestContextParameters.java
The file was modified/software/cicore/trunk/d1_integration/src/main/resources/org/dataone/configuration/context.SANDBOX.test.propertiessrc/main/resources/org/dataone/configuration/context.SANDBOX.test.properties
Revision 16975 by andreib:
Added checks in a few functional test implementations for the ContextAwareTestCaseDataone property that is set based on whether we have v2 nodes in the environment. Some tests will be skipped without v2 nodes in environment.
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/CNAuthTestImplementations.javasrc/test/java/org/dataone/integration/it/testImplementations/CNAuthTestImplementations.java
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/MNSystemMetadataChangedMethodTestImplementations.javasrc/test/java/org/dataone/integration/it/testImplementations/MNSystemMetadataChangedMethodTestImplementations.java
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/NodeRegistryExtensibilityTestImplementations.javasrc/test/java/org/dataone/integration/it/testImplementations/NodeRegistryExtensibilityTestImplementations.java
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/SidCNTestImplementations.javasrc/test/java/org/dataone/integration/it/testImplementations/SidCNTestImplementations.java
Revision 16974 by andreib:
Added a nodeListContainsV2Mn property. It was being set automatically based on the CN node list, but disabled that for now per a discussion with rob since we may just change it to be an environment property.
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/main/java/org/dataone/integration/ContextAwareTestCaseDataone.javasrc/main/java/org/dataone/integration/ContextAwareTestCaseDataone.java
Revision 16935 by rnahf:
added optimization to the createTestObject method in SidCNTestImpl to minimize wait-to-sync time.
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/main/java/org/dataone/integration/ContextAwareTestCaseDataone.javasrc/main/java/org/dataone/integration/ContextAwareTestCaseDataone.java
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/SidCNTestImplementations.javasrc/test/java/org/dataone/integration/it/testImplementations/SidCNTestImplementations.java
Revision 16934 by andreib:
Added a more specific error message and modified some v2 node checks to be even more strict
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/NodeRegistryExtensibilityTestImplementations.javasrc/test/java/org/dataone/integration/it/testImplementations/NodeRegistryExtensibilityTestImplementations.java
Revision 16931 by andreib:
Reverted recent change - object creation test code, in the case that we have a v2 CN.create() with no v2 MNs in the environment, will not fall back to a v1 MN for the authMN because this changes the expected behavior of some tests (tests that are expecting a v2-specific object to be created, aka an object with a v2 authMN). Better that it fail for not finding a v2 authMN than sneakily doing a v1 create where a v2 create is expected.
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/main/java/org/dataone/integration/ContextAwareTestCaseDataone.javasrc/main/java/org/dataone/integration/ContextAwareTestCaseDataone.java
Revision 16930 by andreib:
Object creation test code fix - in the case that we have a v2 CN.create() with no v2 MNs in the environment, fall back to a v1 MN for the authMN.
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/main/java/org/dataone/integration/ContextAwareTestCaseDataone.javasrc/main/java/org/dataone/integration/ContextAwareTestCaseDataone.java
Revision 16929 by andreib:
Improved a few log messages.
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/ViewFunctionalTestImplementations.javasrc/test/java/org/dataone/integration/it/testImplementations/ViewFunctionalTestImplementations.java
Revision 16927 by andreib:
Removed a line that shouldn't have been part of last commit
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/ViewTestImplementations.javasrc/test/java/org/dataone/integration/it/testImplementations/ViewTestImplementations.java
Revision 16926 by andreib:
Fixed a bad typo
Change TypePath in RepositoryPath in Workspace
The file was modified/software/cicore/trunk/d1_integration/src/test/java/org/dataone/integration/it/testImplementations/ViewTestImplementations.javasrc/test/java/org/dataone/integration/it/testImplementations/ViewTestImplementations.java